Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host cleanup fails with kubeadm not found error #298

Closed
anusha94 opened this issue Jan 10, 2022 · 2 comments · Fixed by #333
Closed

Host cleanup fails with kubeadm not found error #298

anusha94 opened this issue Jan 10, 2022 · 2 comments · Fixed by #333
Assignees
Labels
area/code-quality kind/bug Something isn't working
Milestone

Comments

@anusha94
Copy link
Contributor

What steps did you take and what happened:

  • follow the getting_started guide to create workload cluster on VMs
  • the k8s components installation failed due to some reason
  • now the reset host method kicks in attempting to execute kubeadm reset --force
  • since the k8s components were not installed, kubeadm is not installed, therefore kubeadm not found error

What did you expect to happen:

  • host should be reset and back to Waiting for MachineRef state

Anything else you would like to add:
In the hostCleanup function, resetNode should be called only if K8sComponentsInstallationSucceeded Condition is true --> this means kubeadm will be present on the machine.

func (r *HostReconciler) hostCleanUp(ctx context.Context, byoHost *infrastructurev1beta1.ByoHost) error {
logger := ctrl.LoggerFrom(ctx)
logger.Info("cleaning up host")
err := r.resetNode(ctx, byoHost)
if err != nil {
return err
}

@anusha94 anusha94 added kind/bug Something isn't working area/code-quality labels Jan 10, 2022
@anusha94 anusha94 added this to the v0.1.1 milestone Jan 10, 2022
@NilanjanDaw
Copy link
Contributor

I can look into this one.

@anusha94
Copy link
Contributor Author

/assign @NilanjanDaw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code-quality kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants