-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tabs): add actions section #1620
Conversation
👋 @dtsanevmw,
Thank you, 🤖 Clarity Release Bot |
d8a80eb
to
81ebf36
Compare
This comment was marked as outdated.
This comment was marked as outdated.
81ebf36
to
89c408d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
89c408d
to
8500c68
Compare
This comment was marked as outdated.
This comment was marked as outdated.
8500c68
to
d1acb23
Compare
This comment was marked as outdated.
This comment was marked as outdated.
d1acb23
to
0579b28
Compare
This PR introduces visual changes: 32c4fb2
|
b903116
to
c1fd75c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHeck my comments.
This PR introduces visual changes: 866959f
|
d7c009f
to
6811415
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-16.x 16.x
# Navigate to the new working tree
cd .worktrees/backport-16.x
# Create a new branch
git switch --create backport-1620-to-16.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 16219ae3aecfab5b214f64fe118c08321ceed1f1
# Push it to GitHub
git push --set-upstream origin backport-1620-to-16.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-16.x Then, create a pull request where the |
Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval What kind of change does this PR introduce? 1: Slot which is being projected inside the header so basically `<clr-tabs-actions>Whatever content you put here</clr-tabs-actions>`. 2: Directive `clrTabsAction` which you put on the element you want to be interactable and part of the navigation of tabs ( arrows ). <!-- Please check the one that applies to this PR using "x". --> - [ ] Bugfix - [X] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-2391 - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> --------- Co-authored-by: GitHub <[email protected]>
Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval What kind of change does this PR introduce? 1: Slot which is being projected inside the header so basically `<clr-tabs-actions>Whatever content you put here</clr-tabs-actions>`. 2: Directive `clrTabsAction` which you put on the element you want to be interactable and part of the navigation of tabs ( arrows ). <!-- Please check the one that applies to this PR using "x". --> - [ ] Bugfix - [X] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-2391 - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> --------- Co-authored-by: GitHub <[email protected]>
Backport of #1620 --------- Co-authored-by: GitHub <[email protected]>
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
1: Slot which is being projected inside the header so basically
<clr-tabs-actions>Whatever content you put here</clr-tabs-actions>
.2: Directive
clrTabsAction
which you put on the element you want to be interactable and part of the navigation of tabs ( arrows ).What is the current behavior?
Issue Number: CDE-2391
What is the new behavior?
Does this PR introduce a breaking change?
Other information