Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): add actions section #1620

Merged
merged 4 commits into from
Nov 21, 2024
Merged

feat(tabs): add actions section #1620

merged 4 commits into from
Nov 21, 2024

Conversation

dtsanevmw
Copy link
Contributor

@dtsanevmw dtsanevmw commented Nov 18, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

1: Slot which is being projected inside the header so basically <clr-tabs-actions>Whatever content you put here</clr-tabs-actions>.
2: Directive clrTabsAction which you put on the element you want to be interactable and part of the navigation of tabs ( arrows ).

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-2391

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Nov 18, 2024

👋 @dtsanevmw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/cde-2391 branch 6 times, most recently from d8a80eb to 81ebf36 Compare November 19, 2024 08:08

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Contributor

This PR introduces visual changes: 32c4fb2
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/cde-2391
git fetch https://github.com/vmware-clarity/ng-clarity.git 32c4fb2e80c767bb248faac84ec951fbb7964c34
git cherry-pick 32c4fb2e80c767bb248faac84ec951fbb7964c34
git push

@dtsanevmw dtsanevmw marked this pull request as ready for review November 20, 2024 08:16
@dtsanevmw dtsanevmw requested a review from a team November 20, 2024 08:16
@dtsanevmw dtsanevmw self-assigned this Nov 20, 2024
Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHeck my comments.

projects/angular/src/layout/tabs/tabs-actions.ts Outdated Show resolved Hide resolved
Copy link
Contributor

This PR introduces visual changes: 866959f
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/cde-2391
git fetch https://github.com/vmware-clarity/ng-clarity.git 866959f5d26c84a8b57f67a59af5346ddb65081a
git cherry-pick 866959f5d26c84a8b57f67a59af5346ddb65081a
git push

@dtsanevmw dtsanevmw merged commit 16219ae into main Nov 21, 2024
11 checks passed
@dtsanevmw dtsanevmw deleted the dtsanevmw/cde-2391 branch November 21, 2024 13:44
Copy link
Contributor

The backport to 16.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-16.x 16.x
# Navigate to the new working tree
cd .worktrees/backport-16.x
# Create a new branch
git switch --create backport-1620-to-16.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 16219ae3aecfab5b214f64fe118c08321ceed1f1
# Push it to GitHub
git push --set-upstream origin backport-1620-to-16.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-16.x

Then, create a pull request where the base branch is 16.x and the compare/head branch is backport-1620-to-16.x.

dtsanevmw added a commit that referenced this pull request Nov 25, 2024
Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

What kind of change does this PR introduce?

1: Slot which is being projected inside the header so basically
`<clr-tabs-actions>Whatever content you put here</clr-tabs-actions>`.
2: Directive `clrTabsAction` which you put on the element you want to be
interactable and part of the navigation of tabs ( arrows ).

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [X] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: CDE-2391

- [ ] Yes
- [X] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

---------

Co-authored-by: GitHub <[email protected]>
dtsanevmw added a commit that referenced this pull request Nov 25, 2024
Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

What kind of change does this PR introduce?

1: Slot which is being projected inside the header so basically
`<clr-tabs-actions>Whatever content you put here</clr-tabs-actions>`.
2: Directive `clrTabsAction` which you put on the element you want to be
interactable and part of the navigation of tabs ( arrows ).

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [X] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: CDE-2391

- [ ] Yes
- [X] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

---------

Co-authored-by: GitHub <[email protected]>
dtsanevmw added a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants