Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datagrid): disable and hide open detail button #1525

Merged
merged 17 commits into from
Sep 5, 2024

Conversation

valentin-mladenov
Copy link
Contributor

@valentin-mladenov valentin-mladenov commented Aug 29, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Opening details on a datagrid is always possible.

Issue Number: CDE-1073

What is the new behavior?

Datagrid row details can be disabled.
Datagrid row open details button can be disabled.
Datagrid row open details button can be hidden.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Aug 29, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@valentin-mladenov valentin-mladenov changed the title Datagrid disabled detail chevron cde 1073 feat(datagrid ): disable open detail button Aug 30, 2024
@valentin-mladenov valentin-mladenov marked this pull request as ready for review August 30, 2024 10:11
@valentin-mladenov valentin-mladenov changed the title feat(datagrid ): disable open detail button feat(datagrid): disable open detail button Aug 30, 2024
Copy link
Contributor

This PR introduces visual changes: 4a8f051
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout datagrid-disabled-detail-chevron_cde-1073
git fetch https://github.com/vmware-clarity/ng-clarity.git 4a8f0515bc9ddd3446fd2fccf851a6df48eaea7d
git cherry-pick 4a8f0515bc9ddd3446fd2fccf851a6df48eaea7d
git push

@valentin-mladenov valentin-mladenov requested a review from a team August 30, 2024 13:06
Copy link
Contributor

@dtsanevmw dtsanevmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comments as discussed offline.

.storybook/stories/datagrid/datagrid-detail.stories.ts Outdated Show resolved Hide resolved
.storybook/stories/datagrid/datagrid-detail.stories.ts Outdated Show resolved Hide resolved
.storybook/stories/datagrid/datagrid-detail.stories.ts Outdated Show resolved Hide resolved
projects/angular/clarity.api.md Outdated Show resolved Hide resolved
projects/angular/clarity.api.md Outdated Show resolved Hide resolved
projects/angular/src/data/datagrid/datagrid-row.html Outdated Show resolved Hide resolved
projects/angular/src/data/datagrid/datagrid-row.html Outdated Show resolved Hide resolved
projects/angular/src/data/datagrid/datagrid-row.ts Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Sep 3, 2024

This PR introduces visual changes: 9e62e7a
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout datagrid-disabled-detail-chevron_cde-1073
git fetch https://github.com/vmware-clarity/ng-clarity.git 9e62e7adaac2d717e518272a3a68a1f75b2c39d6
git cherry-pick 9e62e7adaac2d717e518272a3a68a1f75b2c39d6
git push

@valentin-mladenov valentin-mladenov changed the title feat(datagrid): disable open detail button feat(datagrid): disable and hide open detail button Sep 3, 2024
@kevinbuhmann
Copy link
Member

Do we have guidance on when to disable vs. hide the open detail button? I'd like to review the documentation changes.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

This PR introduces visual changes: caadf45
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout datagrid-disabled-detail-chevron_cde-1073
git fetch https://github.com/vmware-clarity/ng-clarity.git caadf4509622a8b9dfcbd7da2175ba0751386bc7
git cherry-pick caadf4509622a8b9dfcbd7da2175ba0751386bc7
git push

Copy link
Contributor

github-actions bot commented Sep 4, 2024

This PR introduces visual changes: d9bca9a
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout datagrid-disabled-detail-chevron_cde-1073
git fetch https://github.com/vmware-clarity/ng-clarity.git d9bca9a2ad94f01d64fb769d8cb8f142bf89d6d0
git cherry-pick d9bca9a2ad94f01d64fb769d8cb8f142bf89d6d0
git push

Copy link
Contributor

github-actions bot commented Sep 4, 2024

This PR introduces visual changes: 328edcd
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout datagrid-disabled-detail-chevron_cde-1073
git fetch https://github.com/vmware-clarity/ng-clarity.git 328edcdbe68b12bebee4e356713bee539c21c0ef
git cherry-pick 328edcdbe68b12bebee4e356713bee539c21c0ef
git push

@valentin-mladenov valentin-mladenov merged commit 184854f into main Sep 5, 2024
8 checks passed
@valentin-mladenov valentin-mladenov deleted the datagrid-disabled-detail-chevron_cde-1073 branch September 5, 2024 06:09
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants