Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): backdrop click focus to title (backport to 16.x) #1514

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

valentin-mladenov
Copy link
Contributor

Backport bb5dafe from #1508.
## PR Checklist

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

  • Combobox text line height is relative to parent.

Issue Number: CDE-2232

What is the new behavior?

  • Combobox text line height is seto 20px equal to regular body line height.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@valentin-mladenov valentin-mladenov self-assigned this Aug 9, 2024
@valentin-mladenov valentin-mladenov marked this pull request as ready for review August 9, 2024 08:00
Copy link
Contributor

github-actions bot commented Aug 9, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

github-actions bot commented Aug 9, 2024

This PR introduces visual changes: dab0ffa
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout combobox-relative-line-height_cde-2232_16.x
git fetch https://github.com/vmware-clarity/ng-clarity.git dab0ffacb181fa469e6dbdff04e4fcd6a818c75b
git cherry-pick dab0ffacb181fa469e6dbdff04e4fcd6a818c75b
git push

@valentin-mladenov valentin-mladenov merged commit c464495 into 16.x Aug 9, 2024
7 checks passed
@valentin-mladenov valentin-mladenov deleted the combobox-relative-line-height_cde-2232_16.x branch August 9, 2024 09:46
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants