fix(datagrid): propagate cell rendering changes only to owned rows #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, 🤖 Clarity Release Bot |
This change prevents propagation of cell rendering changes to rows owned by nested datagrids.
kevinbuhmann
force-pushed
the
kevin/nested-cell-rendering-fix
branch
from
fa7cc73
to
3654707
Compare
valentin-mladenov
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
LGTM
@kevinbuhmann can you add, here or in a separeate PR, a demo page and/or storybook example for nested datagrids (in details and expanded rows) to be easily visually tested. A lot of people are using those patterns.
|
We have a datagrid nested in a datagrid detail in the stories. A datagrid nested in an expandable row is not a valid pattern for accessibility reasons. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents propagation of cell rendering changes to rows owned by nested datagrids.
CDE-2199
closes #1485
PR Checklist
PR Type
Bugfix
What is the current behavior?
If the detail pane of a datagrid contains another datagrid with less columns than the outer datagrid, closing the detail pane results in the error:
row.cells.get(...) is undefined.Issue Number: #1485, CDE-2199
What is the new behavior?
No error is thrown, and the correct cells are hidden.
Does this PR introduce a breaking change?
No.