Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datagrid column width calculation applying to wrong column when using expanded row #1487

Closed
1 task done
oznu opened this issue Jul 20, 2024 · 3 comments
Closed
1 task done

Datagrid column width calculation applying to wrong column when using expanded row #1487

oznu opened this issue Jul 20, 2024 · 3 comments
Assignees
@dtsanevmw

Comments

@oznu
Copy link

oznu commented Jul 20, 2024 •
edited
Loading

This is a bug report for the @clr Angular or UI versions of the design system.
For the web-component implementation of Clarity (@cds), visit vmware-clarity/core.

If you are a VMware employee or a contractor in VMware, please use our support space in Google Chat to raise Clarity issues.

Describe the bug

When using the Datagrid with expandable rows, the width applied to each column is the width for the column to it's left when using expandable rows (specifically with *clrIfExpanded)

eg.

col 1 col 2 col 3 col 4
> has width of expand toggle?? has width of col 1 has width of col 2 has width of col 3
>
>

How to reproduce

Issue is easily reproduced and shown here:

https://stackblitz.com/edit/clarity-dark-theme-clr17-wdd6fj?file=src%2Fapp%2Fapp.component.html

image

Versions

Clarity version:

  • v17.2.1

Framework version:

Angular 17

Device:

  • Type: macOS
  • OS: macOS
  • Browser: Edge
  • Version: Latest

Additional notes

This issue was not present in 17.1.0.
@kumart-netapp
Copy link

We are also seeing this issue with latest 16.x version update

@dtsanevmw dtsanevmw self-assigned this Oct 2, 2024
@dtsanevmw dtsanevmw mentioned this issue Oct 7, 2024
Merged
13 tasks
dtsanevmw added a commit that referenced this issue Oct 7, 2024
@dtsanevmw
fix(datagrid): remove expand cell from calculations (#1581)
a51d2d8 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [X] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
Expandable rows first cell with the trigger it's rendered when
calculations are happening and it's creating wrong widths for columns.
![Screenshot 2024-10-04 at 16 42
58](https://github.com/user-attachments/assets/5e359770-5488-47a9-9ec7-4e63ed1e75ae)

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: #1487

## What is the new behavior?
That cell is excluded from calculations and they are correct.
![Screenshot 2024-10-04 at 16 43
47](https://github.com/user-attachments/assets/c7e0c6d2-19f7-4dd4-a8de-21fe79fe436c)


## Does this PR introduce a breaking change?

- [ ] Yes
- [X] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information
github-actions bot pushed a commit that referenced this issue Oct 7, 2024
@dtsanevmw @github-actions
fix(datagrid): remove expand cell from calculations (#1581)
7499c17 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [X] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
Expandable rows first cell with the trigger it's rendered when
calculations are happening and it's creating wrong widths for columns.
![Screenshot 2024-10-04 at 16 42
58](https://github.com/user-attachments/assets/5e359770-5488-47a9-9ec7-4e63ed1e75ae)

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: #1487

## What is the new behavior?
That cell is excluded from calculations and they are correct.
![Screenshot 2024-10-04 at 16 43
47](https://github.com/user-attachments/assets/c7e0c6d2-19f7-4dd4-a8de-21fe79fe436c)

## Does this PR introduce a breaking change?

- [ ] Yes
- [X] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

(cherry picked from commit a51d2d8)
@github-actions github-actions bot mentioned this issue Oct 7, 2024
Merged
13 tasks
dtsanevmw added a commit that referenced this issue Oct 8, 2024
@github-actions @dtsanevmw
fix(datagrid): remove expand cell from calculations (backport to 16.x) (
337a896 
#1582)

Backport a51d2d8 from #1581. <br> ## PR
Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

&lt;!-- Please check the one that applies to this PR using
&quot;x&quot;. --&gt;

- [X] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
Expandable rows first cell with the trigger it&#39;s rendered when
calculations are happening and it&#39;s creating wrong widths for
columns.
![Screenshot 2024-10-04 at 16 42
58](https://github.com/user-attachments/assets/5e359770-5488-47a9-9ec7-4e63ed1e75ae)

&lt;!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. --&gt;

Issue Number: #1487

## What is the new behavior?
That cell is excluded from calculations and they are correct.
![Screenshot 2024-10-04 at 16 43
47](https://github.com/user-attachments/assets/c7e0c6d2-19f7-4dd4-a8de-21fe79fe436c)


## Does this PR introduce a breaking change?

- [ ] Yes
- [X] No

&lt;!-- If this PR contains a breaking change, please describe the
impact and migration path for existing applications below. --&gt;

## Other information

Co-authored-by: Daniel Tsanev <[email protected]>
@dtsanevmw
Copy link
Contributor

Fixed in a51d2d8 and it will be in the next release

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dtsanevmw dtsanevmw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oznu @kumart-netapp @dtsanevmw