-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(file-input): prevent wrapping clear button to next line #1481
Conversation
Thank you, 🤖 Clarity Release Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add visual regrssion tests.
3565128
to
c707ca2
Compare
This PR introduces visual changes: a68e31b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-16.x 16.x
# Navigate to the new working tree
cd .worktrees/backport-16.x
# Create a new branch
git switch --create backport-1481-to-16.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e451240621ce5c1e79ffd7c34b78bf0321170631
# Push it to GitHub
git push --set-upstream origin backport-1481-to-16.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-16.x Then, create a pull request where the |
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
CDE-2183
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
Bugfix
What is the current behavior?
The file input clear button will wrap the next line when placed in a constrained container.
Issue Number: CDE-2183
What is the new behavior?
The file input clear button will not wrap the next line when placed in a constrained container.
Does this PR introduce a breaking change?
No.