Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file-input): prevent wrapping clear button to next line #1481

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

kevinbuhmann
Copy link
Member

@kevinbuhmann kevinbuhmann commented Jul 15, 2024

CDE-2183

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • [N/A] Docs have been added / updated (for bug fixes / features)
  • [N/A] If applicable, have a visual design approval

PR Type

Bugfix

What is the current behavior?

The file input clear button will wrap the next line when placed in a constrained container.

Issue Number: CDE-2183

What is the new behavior?

The file input clear button will not wrap the next line when placed in a constrained container.

Does this PR introduce a breaking change?

No.

Copy link
Contributor

github-actions bot commented Jul 15, 2024

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add visual regrssion tests.

Copy link
Contributor

This PR introduces visual changes: a68e31b
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout kevin/file-picker-wrapping
git fetch https://github.com/vmware-clarity/ng-clarity.git a68e31b8ea7c52d513c1ee99e5906ebb3b9b0856
git cherry-pick a68e31b8ea7c52d513c1ee99e5906ebb3b9b0856
git push

Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinbuhmann kevinbuhmann merged commit e451240 into main Jul 15, 2024
7 checks passed
@kevinbuhmann kevinbuhmann deleted the kevin/file-picker-wrapping branch July 15, 2024 18:07
Copy link
Contributor

The backport to 16.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-16.x 16.x
# Navigate to the new working tree
cd .worktrees/backport-16.x
# Create a new branch
git switch --create backport-1481-to-16.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e451240621ce5c1e79ffd7c34b78bf0321170631
# Push it to GitHub
git push --set-upstream origin backport-1481-to-16.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-16.x

Then, create a pull request where the base branch is 16.x and the compare/head branch is backport-1481-to-16.x.

kevinbuhmann added a commit that referenced this pull request Jul 15, 2024
kevinbuhmann added a commit that referenced this pull request Jul 16, 2024
andyfeds pushed a commit to andyfeds/ng-clarity that referenced this pull request Jul 25, 2024
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants