fix(wizard): redesign wizard stepnav (add success icon and align states)

[kevinbuhmann]

CDE-2229, VPAT-776

PR Checklist

• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• If applicable, have a visual design approval

PR Type

Bugfix

What is the current behavior?

• The step number was removed for steps with error status.
• Only color was used to show wizard step completed status.
• The hover and active states used incorrect text colors.
• The stepnav item had padding resulting in the button (and thus the hover, active, and selected background colors) to be surrounded by padding.

Issue Number: CDE-2229, VPAT-776

What is the new behavior?

• The step number is not removed for steps with error status.
• An icon, in addition to color, is used to show wizard step completed status.
• The hover and active states use correct text colors.
• The stepnav item does not have padding resulting in the button (and thus the hover, active, and selected background colors) not to be surrounded by padding.

Does this PR introduce a breaking change?

No, but some of the wizard CSS custom properties are marked to be renamed in v18.

[github-actions]

👋 @kevinbuhmann,

• 🙏 The Clarity team thanks you for opening a pull request
• 🎉 The build for this PR has succeeded
• 🔍 The PR is now ready for review
• 🍿 In the meantime, view a preview of this PR
• 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

[valentin-mladenov]

It's better to set a proper deprecation steps for clr-wizard-stepnav-item-border-color--active and clr-wizard-stepnav-text--active properties and variables now.

Check the flow from the other CSS deprecatetions.

[valentin-mladenov]

LGTM

[github-actions]

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.