-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): vertical nav - remove incorrect usage of links at top level for the vertical nav story #1455
Conversation
👋 @andyfeds,
Thank you, 🤖 Clarity Release Bot |
This PR introduces visual changes: 62e6d87
|
This PR introduces visual changes: c163f9c
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This is a bug in the vertical nav routing story, and not the vertical nav component. Links are used in the top level for the nav with routing story which results in an independent accordion icon button being added to the DOM that has state but no label.
The top-level entries should not be links. That usage is incorrect and breaks the component.
Issue Number: CDE-1390
What is the new behavior?
Does this PR introduce a breaking change?
Other information
This will fix related bug : CDE-1391