Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): vertical nav - remove incorrect usage of links at top level for the vertical nav story #1455

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

andyfeds
Copy link
Contributor

@andyfeds andyfeds commented Jun 20, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

This is a bug in the vertical nav routing story, and not the vertical nav component. Links are used in the top level for the nav with routing story which results in an independent accordion icon button being added to the DOM that has state but no label.
The top-level entries should not be links. That usage is incorrect and breaks the component.

Issue Number: CDE-1390

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This will fix related bug : CDE-1391

Copy link
Contributor

github-actions bot commented Jun 20, 2024

👋 @andyfeds,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@andyfeds andyfeds self-assigned this Jun 20, 2024
Copy link
Contributor

This PR introduces visual changes: 62e6d87
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout a11y/CDE-1390
git fetch https://github.com/vmware-clarity/ng-clarity.git 62e6d879af032854daed5f6e91050fed48c18e5b
git cherry-pick 62e6d879af032854daed5f6e91050fed48c18e5b
git push

Copy link
Contributor

This PR introduces visual changes: c163f9c
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout a11y/CDE-1390
git fetch https://github.com/vmware-clarity/ng-clarity.git c163f9c246f81789b7e760c841b02115a0863707
git cherry-pick c163f9c246f81789b7e760c841b02115a0863707
git push

@kevinbuhmann kevinbuhmann changed the title fix(a11y): vertical nav - remove incorrect usage of links at top level for the vertical nav story chore(a11y): vertical nav - remove incorrect usage of links at top level for the vertical nav story Jun 20, 2024
@kevinbuhmann kevinbuhmann changed the title chore(a11y): vertical nav - remove incorrect usage of links at top level for the vertical nav story fix(a11y): vertical nav - remove incorrect usage of links at top level for the vertical nav story Jun 20, 2024
@andyfeds andyfeds merged commit b21e36e into vmware-clarity:main Jun 20, 2024
7 checks passed
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants