fix(combobox): enable screen readers to announce "no results" properly #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, 🤖 Clarity Release Bot |
kevinbuhmann
requested changes
Mar 13, 2024
Co-authored-by: Kevin Buhmann <[email protected]>
kevinbuhmann
approved these changes
Mar 13, 2024
kevinbuhmann
requested changes
Mar 13, 2024
|
I think the PR title should reworded to describe the functional change instead of the technical change. I would say 'enable screen readers to announce "no results" properly' or similar. |
mivaylo
changed the title
kevinbuhmann
force-pushed
the
cde-1515-no-results-a11y-screen-reader-main
branch
from
3d4a1c8 to
d682d5f
Compare
kevinbuhmann
force-pushed
the
cde-1515-no-results-a11y-screen-reader-main
branch
from
d682d5f to
394aed8
Compare
kevinbuhmann
approved these changes
Apr 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
#1316) CDE-1515 Co-authored-by: Kevin Buhmann <[email protected]> (cherry picked from commit a158ac7)
kevinbuhmann
added a commit
that referenced
this pull request
Apr 3, 2024
#1344) This is a backport a158ac7 (#1316) to 16.x. CDE-1515 Co-authored-by: Kevin Buhmann <[email protected]> Co-authored-by: mivaylo <[email protected]>
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: CDE-1515
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Current NVDA voiceover behavior (notice for "USA" as there are no results it doesn't say "Dialog, list, no results"):
current behaviour.webm
And with the changes you can hear how NVDA says "List, no results":
after-changes.webm