fix(tabs): fix aria-labelledby attribute #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @mivaylo,
Thank you, 🤖 Clarity Release Bot |
kevinbuhmann
requested changes
Mar 11, 2024
Co-authored-by: Kevin Buhmann <[email protected]>
kevinbuhmann
approved these changes
Mar 11, 2024
Updated with this commit, thanks |
mivaylo
added a commit
that referenced
this pull request
Mar 12, 2024
## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-1354 ## What is the new behavior? ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information This PR fixes getter method ariaLabelledBy to return correct tabLinkId. Previously nothing was found in the getter function so the aria-labelledby attrbute was not set. To be able to find the correct tabLink I had to expose a getter of the id of the tabLink. --------- Co-authored-by: Kevin Buhmann <[email protected]>
13 tasks
mivaylo
added a commit
that referenced
this pull request
Mar 12, 2024
## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-1354 ## What is the new behavior? ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information This PR fixes getter method ariaLabelledBy to return correct tabLinkId. Previously nothing was found in the getter function so the aria-labelledby attrbute was not set. To be able to find the correct tabLink I had to expose a getter of the id of the tabLink. --------- Co-authored-by: Kevin Buhmann <[email protected]>
13 tasks
mivaylo
added a commit
that referenced
this pull request
Mar 12, 2024
## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-1354 ## What is the new behavior? ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information This PR fixes getter method ariaLabelledBy to return correct tabLinkId. Previously nothing was found in the getter function so the aria-labelledby attrbute was not set. To be able to find the correct tabLink I had to expose a getter of the id of the tabLink. Port of #1309 to 16.x Co-authored-by: Kevin Buhmann <[email protected]>
mivaylo
added a commit
that referenced
this pull request
Mar 12, 2024
## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-1354 ## What is the new behavior? ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information This PR fixes getter method ariaLabelledBy to return correct tabLinkId. Previously nothing was found in the getter function so the aria-labelledby attrbute was not set. To be able to find the correct tabLink I had to expose a getter of the id of the tabLink. This is a port of #1309 to 15.x Co-authored-by: Kevin Buhmann <[email protected]>
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: CDE-1354
What is the new behavior?
Does this PR introduce a breaking change?
Other information
This PR fixes getter method ariaLabelledBy to return correct tabLinkId. Previously nothing was found in the getter function so the aria-labelledby attrbute was not set. To be able to find the correct tabLink I had to expose a getter of the id of the tabLink.