Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wizard): allow long page titles to wrap in stepnav (backport to 15.x) #1232

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

williamernest
Copy link
Contributor

@williamernest williamernest commented Feb 13, 2024

Backport dc52751 from #1211.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Longer page titles in the wizard do not wrap, resulting in some text being hidden. Longer text strings are necessary for internationalization, as relative short titles in english can become much longer in other languages.

Issue Number: CDE-1648, CDE-1645

Longer page titles will wrap when listed in the step nav.

  • Yes
  • No

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [x] If applicable, have a visual design approval

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

Longer page titles in the wizard do not wrap, resulting in some text
being hidden. Longer text strings are necessary for
internationalization, as relative short titles in english can become
much longer in other languages.

Issue Number: CDE-1648, CDE-1645

Longer page titles will wrap when listed in the step nav.

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

---------

Co-authored-by: GitHub <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 13, 2024

👋 @williamernest,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

This PR introduces visual changes: 38a6120
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout wernest/backport_1211_to_15
git fetch https://github.com/vmware-clarity/ng-clarity.git 38a6120f9210cea4011a6e3cca2e10bb9782f97d
git cherry-pick 38a6120f9210cea4011a6e3cca2e10bb9782f97d
git push

@williamernest williamernest merged commit 79ac0c3 into 15.x Feb 13, 2024
6 checks passed
@williamernest williamernest deleted the wernest/backport_1211_to_15 branch February 13, 2024 20:58
Copy link
Contributor

🎉 This PR is included in version 15.14.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants