fix(button): icon text misalignment when clrLoading is used

[valentin-mladenov]

PR Checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Icon and text are misaligned vertically and horizontally when clrLoading is used.

Issue Number: CDE-1652

What is the new behavior?

Icon and text are aligned vertically and horizontally to design specification when clrLoading is used.

Does this PR introduce a breaking change?

• Yes
• No

Other information

[github-actions]

👋 @valentin-mladenov,

• 🙏 The Clarity team thanks you for opening a pull request
• 🎉 The build for this PR has succeeded
• 🔍 The PR is now ready for review
• 🍿 In the meantime, view a preview of this PR
• 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

[github-actions]

This PR introduces visual changes: 4577f9c
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout button-icon-text-misalignment_cde-1652
git fetch https://github.com/vmware-clarity/ng-clarity.git 4577f9cd7dd654bae8295e897583585c446e1c35
git cherry-pick 4577f9cd7dd654bae8295e897583585c446e1c35
git push

[github-actions]

This PR introduces visual changes: 7b31ec1
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout button-icon-text-misalignment_cde-1652
git fetch https://github.com/vmware-clarity/ng-clarity.git 7b31ec1408e60b900acf46a69639ea01c53abfa8
git cherry-pick 7b31ec1408e60b900acf46a69639ea01c53abfa8
git push

[github-actions]

The backport to main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport-1224-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b25cd4611709082befe4751c9cba68f8bd0445b7
# Push it to GitHub
git push --set-upstream origin backport-1224-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport-1224-to-main.

[github-actions]

🎉 This PR is included in version 17.0.0 🎉

The release is available on:

• GitHub release
• v17.0.0

Your semantic-release bot 📦🚀

[github-actions]

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.