Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button): change loading button conents from div to span #1181

Merged
merged 2 commits into from
Feb 2, 2024
Merged

fix(button): change loading button conents from div to span #1181

merged 2 commits into from
Feb 2, 2024

Conversation

williamernest
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

In #1141 the loading button contents were added into a div to prevent the button from animating on the initial render.

Issue Number: CDE-1628

What is the new behavior?

The div is changed to a span because adding a div inside of a button is technically not semantically correct html.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024 •
edited
Loading

👋 @williamernest,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@williamernest williamernest force-pushed the wernest/fix_loading_button_div_cde-1628 branch from 47dd669 to d9105b8 Compare January 31, 2024 22:08
@williamernest williamernest changed the base branch from 15.x to next January 31, 2024 22:09
@williamernest williamernest force-pushed the wernest/fix_loading_button_div_cde-1628 branch 2 times, most recently from 5b710b8 to 8df8e8a Compare January 31, 2024 22:11
@williamernest williamernest changed the base branch from next to main January 31, 2024 22:11
@williamernest williamernest force-pushed the wernest/fix_loading_button_div_cde-1628 branch from 8df8e8a to 081db16 Compare January 31, 2024 23:12
kevinbuhmann
kevinbuhmann approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@kevinbuhmann kevinbuhmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, the div was my mistake. Thanks for fixing.

@williamernest williamernest merged commit 24fe115 into main Feb 2, 2024
4 checks passed
@williamernest williamernest deleted the wernest/fix_loading_button_div_cde-1628 branch February 2, 2024 16:37
github-actions bot pushed a commit that referenced this pull request Feb 2, 2024
@williamernest @github-actions
fix(button): change loading button conents from div to span (#1181)
3bb14ce 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

In #1141 the loading button contents were added into a div to prevent
the button from animating on the initial render.

Issue Number: CDE-1628

## What is the new behavior?

The div is changed to a span because adding a div inside of a button is
technically not semantically correct html.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

(cherry picked from commit 24fe115)
@github-actions github-actions bot mentioned this pull request Feb 2, 2024
Merged
13 tasks
github-actions bot pushed a commit that referenced this pull request Feb 2, 2024
@williamernest @github-actions
fix(button): change loading button conents from div to span (#1181)
c421fa4 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

In #1141 the loading button contents were added into a div to prevent
the button from animating on the initial render.

Issue Number: CDE-1628

## What is the new behavior?

The div is changed to a span because adding a div inside of a button is
technically not semantically correct html.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

(cherry picked from commit 24fe115)
@github-actions github-actions bot mentioned this pull request Feb 2, 2024
Merged
13 tasks
williamernest added a commit that referenced this pull request Feb 2, 2024
@github-actions @williamernest
fix(button): change loading button contents from div to span (backpor…
fd763f8 
…t to next) (#1190)

Backport 24fe115 from #1181. <br> ## PR
Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

&lt;!-- Please check the one that applies to this PR using
&quot;x&quot;. --&gt;

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

In #1141 the loading button contents were added into a div to prevent
the button from animating on the initial render.

Issue Number: CDE-1628

## What is the new behavior?

The div is changed to a span because adding a div inside of a button is
technically not semantically correct html.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

&lt;!-- If this PR contains a breaking change, please describe the
impact and migration path for existing applications below. --&gt;

## Other information

Co-authored-by: Will Ernest <[email protected]>
williamernest added a commit that referenced this pull request Feb 2, 2024
@github-actions @williamernest
fix(button): change loading button contents from div to span (backpor…
d084d00 
…t to 15.x) (#1191)

Backport 24fe115 from #1181. <br> ## PR
Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

&lt;!-- Please check the one that applies to this PR using
&quot;x&quot;. --&gt;

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

In #1141 the loading button contents were added into a div to prevent
the button from animating on the initial render.

Issue Number: CDE-1628

## What is the new behavior?

The div is changed to a span because adding a div inside of a button is
technically not semantically correct html.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

&lt;!-- If this PR contains a breaking change, please describe the
impact and migration path for existing applications below. --&gt;

## Other information

Co-authored-by: Will Ernest <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

🎉 This PR is included in version 16.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

dtsanevmw pushed a commit that referenced this pull request Feb 8, 2024
@williamernest @dtsanevmw
fix(button): change loading button conents from div to span (#1181)
482ff3b 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

In #1141 the loading button contents were added into a div to prevent
the button from animating on the initial render.

Issue Number: CDE-1628

## What is the new behavior?

The div is changed to a span because adding a div inside of a button is
technically not semantically correct html.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevinbuhmann kevinbuhmann kevinbuhmann approved these changes

Assignees

@williamernest williamernest

Labels
auto-backport-to-15.x cla-not-required released type:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williamernest @kevinbuhmann @vmwclabot