Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): add title min-width #1163

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

mivaylo
Copy link
Contributor

@mivaylo mivaylo commented Jan 24, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-1601

What is the new behavior?

Since v17 alpha (this commit: b9d6436 ) we used to have accordion / stepper descriptions not aligned vertically due to different width of the preceding element (the title):

image

image

This PR is introducing a min-width property to the element before the descriptions which aligns them vertically:

image

image

As stepper component is inheriting accordion one, this change is observed in both components

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

BREAKING CHANGE: accordion title now have a min-width and exposed a token for it. This resolves to a difference in the layout.

@mivaylo mivaylo marked this pull request as draft January 24, 2024 08:32
@mivaylo mivaylo changed the base branch from main to next January 24, 2024 08:40
Copy link
Contributor

@dtsanevmw dtsanevmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comments

@mivaylo mivaylo changed the title fix(accordion): add title min-width feat(accordion): add title min-width Jan 24, 2024
Copy link
Contributor

github-actions bot commented Jan 24, 2024

👋 @mivaylo,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@mivaylo mivaylo marked this pull request as ready for review January 24, 2024 09:47
Copy link
Contributor

This PR introduces visual changes: 4155d3b
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-1601-accordion-header-misalignment-fix
git fetch https://github.com/vmware-clarity/ng-clarity.git 4155d3bfd251afa1975cee14edeb36e9fd0aa3fa
git cherry-pick 4155d3bfd251afa1975cee14edeb36e9fd0aa3fa
git push

@mivaylo mivaylo merged commit c4b8afd into next Jan 24, 2024
5 checks passed
@mivaylo mivaylo deleted the cde-1601-accordion-header-misalignment-fix branch January 24, 2024 15:09
Copy link
Contributor

🎉 This PR is included in version 17.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants