-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(accordion): add title min-width #1163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check comments
👋 @mivaylo,
Thank you, 🤖 Clarity Release Bot |
This PR introduces visual changes: 4155d3b
|
🎉 This PR is included in version 17.0.0-beta.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: CDE-1601
What is the new behavior?
Since v17 alpha (this commit: b9d6436 ) we used to have accordion / stepper descriptions not aligned vertically due to different width of the preceding element (the title):
This PR is introducing a min-width property to the element before the descriptions which aligns them vertically:
As stepper component is inheriting accordion one, this change is observed in both components
Does this PR introduce a breaking change?
Other information
BREAKING CHANGE: accordion title now have a
min-width
and exposed a token for it. This resolves to a difference in the layout.