feat(datagrid): use only clrDgItemsTrackBy for selection tracking
#1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed two tests that appeared to test an optimization to skip work if there are no items. These optimizations are invalid because it may appear that the datagrid has no items when it just doesn't have items yet. BREAKING CHANGE: The row iterator `trackBy` function will no longer be used for selection tracking. Update your code to pass `clrDgItemsTrackBy` to the `clr-datagrid` component if you pass `trackBy` to the row iterator.
Thank you, 🤖 Clarity Release Bot |
dtsanevmw
approved these changes
Jan 23, 2024
kevinbuhmann
deleted the
kevin/breaking/remove-datagrid-iterator-trackby-fallback
branch
|
🎉 This PR is included in version 17.0.0-beta.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed two tests that appeared to test an optimization to skip work if there are no items. These optimizations are invalid because it may appear that the datagrid has no items when it just doesn't have items yet.
CDE-71
BREAKING CHANGE: The row iterator
trackByfunction will no longer be used for selection tracking. Update your code to passclrDgItemsTrackByto theclr-datagridcomponent if you passtrackByto the row iterator. Note that theclrDgItemsTrackBysignature does not include the element index.