Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forms): support for dynamic control change #1074

Merged
merged 8 commits into from
Dec 21, 2023
Merged

Conversation

dtsanevmw
Copy link
Contributor

@dtsanevmw dtsanevmw commented Nov 23, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

With dynamic controls which are not available initially but when they appear available combined with a value, we don't track that and status validation is not triggered and it stays in NONE state.

Issue Number: CDE-1464

What is the new behavior?

Now we trigger validation if there is a change inside the control and validations works.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Nov 23, 2023

👋 @dtsanevmw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/1464 branch 6 times, most recently from b66ae92 to 9461ad6 Compare November 24, 2023 12:06
@dtsanevmw dtsanevmw changed the title feat(forms): support for dynamic form-control change feat(forms): support for dynamic control change Nov 24, 2023
@dtsanevmw dtsanevmw marked this pull request as ready for review November 24, 2023 17:13
@dtsanevmw dtsanevmw self-assigned this Nov 24, 2023
@dtsanevmw dtsanevmw requested a review from a team November 24, 2023 17:14
@wghglory
Copy link

wghglory commented Dec 8, 2023

Hello @dtsanevmw,

Could you please provide an estimated timeframe for the resolution of this issue? Our product heavily relies on it, and having an idea of when it will be fixed would greatly assist our planning. Thank you for your prompt attention to this matter.

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/1464 branch 2 times, most recently from f3837ac to ea53d08 Compare December 9, 2023 11:53
@dtsanevmw dtsanevmw force-pushed the dtsanevmw/1464 branch 2 times, most recently from 5b0ce96 to 4308bc0 Compare December 12, 2023 06:21
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants