fix(date-picker): add null check for optional date control

[twittwer]

PR Checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

The control property of ClrDateInput's is marked as optional and can therefore be null.

ng-clarity/projects/angular/src/forms/datepicker/date-input.ts

Lines 72 to 74 in 7cfeb3b

	@Self()
	@Optional()
	protected control: NgControl,

  constructor(
    ...
    @Self()
    @Optional()
    protected control: NgControl,
    ...
  ) {
    super(viewContainerRef, ClrDateContainer, injector, control, renderer, el);
  }

But the WrappedControl which is extended by ClrDateInput doesn't handle nullable controls.

ng-clarity/projects/angular/src/forms/common/wrapped-control.ts

Line 57 in 7cfeb3b

private ngControl: NgControl,

  constructor(
    ...
    private ngControl: NgControl,
    ...
  ) {

This causes TypeError: Cannot read properties of null (reading 'control') when using clrDate and calling markAllAsTouched on a surrounding form.

ng-clarity/projects/angular/src/forms/common/wrapped-control.ts

Lines 146 to 149 in 7cfeb3b

	private markAsTouched(): void {
	this.ngControl.control.markAsTouched();
	this.ngControl.control.updateValueAndValidity();
	}

  private markAsTouched(): void {
    this.ngControl.control.markAsTouched();
    this.ngControl.control.updateValueAndValidity();
  }

What is the new behavior?

The WrappedControl is now typed with nullable control and checks for its existence before using it.

Does this PR introduce a breaking change?

• Yes
• No

Other information

[vmwclabot]

@twittwer, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

[github-actions]

👋 @kevinbuhmann,

• 🙏 The Clarity team thanks you for opening a pull request
• 🎉 The build for this PR has succeeded
• 🔍 The PR is now ready for review
• 🍿 In the meantime, view a preview of this PR
• 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

[vmwclabot]

@twittwer, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

[vmwclabot]

@twittwer, VMware has approved your signed contributor license agreement.

[kevinbuhmann]

Thanks!

[twittwer]

@kevinbuhmann How would you like to proceed with the failing test?

ng-clarity/projects/angular/src/forms/datepicker/date-input.spec.ts

Lines 109 to 111 in 7cfeb3b

	it('should set the control on NgControlService', () => {
	expect(setControlSpy).toHaveBeenCalled();
	});

Before it tests that NgControlService.setControl has be called, but not with what. In reality, it was called with null what is not supported by the NgControlService.setControl.

Should I test the opposite and check it is not called, or remove it?

[kevinbuhmann]

We should have a test for both possibilities.

[twittwer]

Ok, I checked it out locally and now lint & test should succeed.

[twittwer]

I hope running public-api:update fixes the pipeline

[twittwer]

@kevinbuhmann What is required to get this merged & released?

[kevinbuhmann]

@kevinbuhmann What is required to get this merged & released?

I will get this merged today.

[twittwer]

Can you say when the next release will be published?
This is currently blocking our update.
Or is there some next/beta tag to install clarity with the fix?

[twittwer]

@kevinbuhmann Can you estimate a time for next release with this fix?

[github-actions]

🎉 This PR is included in version 16.1.0 🎉

The release is available on:

• GitHub release
• v16.1.0

Your semantic-release bot 📦🚀

[github-actions]

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.