Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

[@vcd/ext-cli] Auto-generated plugin should not have memory leaks #214

Open
irahov opened this issue Jul 8, 2021 · 0 comments
Open

[@vcd/ext-cli] Auto-generated plugin should not have memory leaks #214

irahov opened this issue Jul 8, 2021 · 0 comments

Comments

@irahov
Copy link
Contributor

irahov commented Jul 8, 2021

Describe the bug
The autogenerated plugin does not unsubscribe from an observable subscription

To Reproduce
Steps to reproduce the behavior:

  1. Create a new plugin vcd-ext new ...
  2. Take a loook at the autogenerated code:
    this.client.query(Query.Builder.ofType("organization").links(false)).subscribe
    There is no unsubscribe statement.
    Although this is a demo code and most probably it is going to be replaced by the plugin writer it is not goot to suggest code with memory leaks.
    There should be either unsubscribe or pipe(take(1)) statement
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant