Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

In Custom Resources view the Resource Age column is not formatted properly #1462

Closed
danielpacak opened this issue Oct 6, 2020 · 1 comment · Fixed by #2046
Closed

In Custom Resources view the Resource Age column is not formatted properly #1462

danielpacak opened this issue Oct 6, 2020 · 1 comment · Fixed by #2046
Labels
api enhancement New feature or request good first issue Good for newcomers

Comments

@danielpacak
Copy link

danielpacak commented Oct 6, 2020

What steps did you take and what happened:

  1. Define a CR and create an instance of it. For example:
    $ kubectl apply -f https://github.com/aquasecurity/starboard/blob/master/kube/crd/vulnerabilityreports-crd.yaml
    $ kubectl apply -f https://github.com/aquasecurity/starboard/blob/master/kube/examples/vulnerabilities.yaml
    
  2. Navigate to the CR instance in Octant UI
    octant_resource_age
  3. As you can see the Resource Age column is not formatted as date. What's more even if the CR defines Age as additional printer column the CR views renders the redundant Resource Age column

What did you expect to happen:

  1. If a CRD does not define Age as additional printer column then format Resource Age column as date. BTW, I'd probably rename Resource Age to Age to be consistent with kubectl output
  2. If a CRD defines Age as additional printer column then format Age column as date and do not display Resource Age column.

Anything else you would like to add:

N/A

Environment:

  • Octant version (use octant version): 0.16.0
  • Kubernetes version (use kubectl version): 0.19.1
  • OS (macOS 10.15, Windows 10, Ubuntu 19.10 etc): macOS 10.15
@wwitzel3 wwitzel3 added api enhancement New feature or request good first issue Good for newcomers labels Dec 17, 2020
@lenriquez
Copy link
Contributor

@wwitzel3 if you don't mind I can take this one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants