Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Use serde instead of rustc_serialize #94

Closed
andrewjstone opened this issue May 1, 2017 · 2 comments
Closed

Use serde instead of rustc_serialize #94

andrewjstone opened this issue May 1, 2017 · 2 comments
Labels
performance

Comments

@andrewjstone
Copy link
Contributor

rustc_serialize is deprecated. Serde also allows for forwards and backwards compatibility via ignoring fields of new messages on old nodes, and creating default values for missing fields on new nodes.

This PR depends upon andrewjstone/rabble#19

Right now, we also use msgpack as the serialization format, but it appears that bincode is almost twice as fast. However, right now neither of them properly handles the forward/backwards compatibility as provided by serde. An issue has been opened for bincode here
@andrewjstone
Copy link
Contributor Author

Fixed by #96

@andrewjstone
Copy link
Contributor Author

Backwards/Forwards compatibility is still an issue, but one that can be dealt with later.

@andrewjstone andrewjstone reopened this May 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewjstone