Skip to content
This repository has been archived by the owner on Jul 19, 2022. It is now read-only.

Suggestion: Use cfenv to parse CF variables #2

Open
mcowger opened this issue May 17, 2016 · 3 comments
Open

Suggestion: Use cfenv to parse CF variables #2

mcowger opened this issue May 17, 2016 · 3 comments
Assignees

Comments

@mcowger
Copy link

mcowger commented May 17, 2016

https://pypi.python.org/pypi/cfenv/0.4.0

@cdelashmutt-pivotal
Copy link
Contributor

If we were parsing out more than just the PORT environment variable I could see pulling this in. We aren't binding to services right now, but when we do start looking at more than just PORT, I think it makes sense to us cfenv for that.

Is there some other case for cfenv that I'm not considering?

@mcowger
Copy link
Author

mcowger commented Jul 12, 2016

The reason I prefer cfenv is simply because it does the right thing regardless of if you are using Diego or DEA cells - so the code is a bit simpler to support both paradigms.

Its a minor suggestion I dont really have a stake in, but if you are interested in using it I'd be happy to write the patch and PR.

@cdelashmutt-pivotal
Copy link
Contributor

Ahh, that makes sense. I don't have an env to test against DEAs any more, myself. I'm quite ok with you creating a PR for this. If you do create a PR, please include a test for this as well.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants