From 15e8f289d619c573d988bc258cb4f795e4b4feaa Mon Sep 17 00:00:00 2001 From: youkaichao Date: Fri, 26 Apr 2024 09:01:09 -0700 Subject: [PATCH 1/4] add rfc template --- .github/ISSUE_TEMPLATE/750-RFC.yml | 49 ++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/750-RFC.yml diff --git a/.github/ISSUE_TEMPLATE/750-RFC.yml b/.github/ISSUE_TEMPLATE/750-RFC.yml new file mode 100644 index 0000000000000..9108065fee545 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/750-RFC.yml @@ -0,0 +1,49 @@ +name: 💬 Request for comments. +description: Ask for feedback on major architectural changes or design choices. +title: "[RFC]: " +labels: ["RFC"] + +body: +- type: markdown + attributes: + value: > + #### Please take a look at previous [RFCs](https://github.com/vllm-project/vllm/issues?q=label%3ARFC+sort%3Aupdated-desc) for reference. +- type: textarea + attributes: + label: Motivation. + description: > + The motivation of the RFC. + validations: + required: true +- type: textarea + attributes: + label: Proposed Change. + description: > + The proposed change of the RFC. + validations: + required: true +- type: textarea + attributes: + label: Feedback Period. + description: > + The feedback period of the RFC. Usually at least one week. + validations: + required: true +- type: textarea + attributes: + label: CC List. + description: > + The list of people you want to CC. + validations: + required: true +- type: textarea + attributes: + label: Any Other Things. + description: > + Any other things you would like to mention. + validations: + required: false +- type: markdown + attributes: + value: > + Thanks for contributing 🎉! From c461b7b5ca5a9b5d2238e50a28629b4d5ca05713 Mon Sep 17 00:00:00 2001 From: youkaichao Date: Fri, 26 Apr 2024 09:02:41 -0700 Subject: [PATCH 2/4] update title --- .github/ISSUE_TEMPLATE/750-RFC.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/750-RFC.yml b/.github/ISSUE_TEMPLATE/750-RFC.yml index 9108065fee545..d895030e19fdd 100644 --- a/.github/ISSUE_TEMPLATE/750-RFC.yml +++ b/.github/ISSUE_TEMPLATE/750-RFC.yml @@ -1,4 +1,4 @@ -name: 💬 Request for comments. +name: 💬 Request for comments (RFC). description: Ask for feedback on major architectural changes or design choices. title: "[RFC]: " labels: ["RFC"] From 67f0e903ae6237d2259d17ec9c828584e2508622 Mon Sep 17 00:00:00 2001 From: youkaichao Date: Fri, 26 Apr 2024 11:52:26 -0700 Subject: [PATCH 3/4] Update .github/ISSUE_TEMPLATE/750-RFC.yml Co-authored-by: Simon Mo --- .github/ISSUE_TEMPLATE/750-RFC.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/750-RFC.yml b/.github/ISSUE_TEMPLATE/750-RFC.yml index d895030e19fdd..bb4cc0e90dc94 100644 --- a/.github/ISSUE_TEMPLATE/750-RFC.yml +++ b/.github/ISSUE_TEMPLATE/750-RFC.yml @@ -35,7 +35,7 @@ body: description: > The list of people you want to CC. validations: - required: true + required: false - type: textarea attributes: label: Any Other Things. From 777a52749ec4be7ed52825439f9ea952ac595bf8 Mon Sep 17 00:00:00 2001 From: youkaichao Date: Fri, 26 Apr 2024 11:52:32 -0700 Subject: [PATCH 4/4] Update .github/ISSUE_TEMPLATE/750-RFC.yml Co-authored-by: Simon Mo --- .github/ISSUE_TEMPLATE/750-RFC.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/750-RFC.yml b/.github/ISSUE_TEMPLATE/750-RFC.yml index bb4cc0e90dc94..5382b124dcd79 100644 --- a/.github/ISSUE_TEMPLATE/750-RFC.yml +++ b/.github/ISSUE_TEMPLATE/750-RFC.yml @@ -28,7 +28,7 @@ body: description: > The feedback period of the RFC. Usually at least one week. validations: - required: true + required: false - type: textarea attributes: label: CC List.