Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc]: Unit test failures with BlockManager v2 #8718

Closed
1 task done
sroy745 opened this issue Sep 22, 2024 · 1 comment
Closed
1 task done

[Misc]: Unit test failures with BlockManager v2 #8718

sroy745 opened this issue Sep 22, 2024 · 1 comment
Labels
help wanted Extra attention is needed misc P0

Comments

@sroy745
Copy link
Collaborator

sroy745 commented Sep 22, 2024

Anything you want to discuss about vllm.

We plan to deprecate BlockManager V1 in favor of BlockManager V2. As part of that deprecation process we want to make sure that all existing tests work with BlockManager V2. We will use this issue to track the unit tests that fail with BlockManager V2 and fix them.

To that end we are using #8678 to identify the unit tests that break with BlockManager V2

The unit tests that have identified as failing currently are

tests/basic_correctness

tests/basic_correctness/test_preemption.py::test_swap_infeasible[4-96-float-facebook/opt-125m]

tests/core

test_chunked_prefill_scheduler.py::test_chunk test_chunked_prefill_scheduler.py::test_complex test_chunked_prefill_scheduler.py::test_prompt_limit test_chunked_prefill_scheduler.py::test_swap test_chunked_prefill_scheduler.py::test_running_prefill_prioritized_over_swap test_chunked_prefill_scheduler.py::test_chunked_prefill_preempt test_chunked_prefill_scheduler.py::test_chunked_prefill_max_seqs
test_scheduler.py::test_scheduler_prefill_prioritized test_scheduler.py::test_swapped_out_prioritized test_scheduler.py::test_prefill_schedule_token_budget test_scheduler.py::test_prefill_schedule_max_seqs
test_scheduler.py::test_prefill_schedule_max_lora test_scheduler.py::test_decode_schedule_preempted test_scheduler.py::test_decode_swap_beam_search test_scheduler.py::test_schedule_decode_blocks_to_copy_update
test_scheduler.py::test_schedule_swapped_simple test_scheduler.py::test_schedule_swapped_max_token_budget test_scheduler.py::test_schedule_swapped_max_seqs test_scheduler.py::test_schedule_swapped_max_loras test_scheduler.py::test_schedule_swapped_cannot_swap_in test_scheduler.py::test_infeasible_swap test_scheduler.py::test_schedule_swapped_blocks_to_copy

I found some other failures but they might be related to my local environment not supporting kernels like flash-infer and not to BlockManager V2.

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed misc P0
Projects
None yet
Development

No branches or pull requests

3 participants