-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Installation]: LGPL license in dependencies #8030
Comments
Perhaps we could move audio support to an "extra" optional dependency and instruct users to install using |
I didn't consider licensing issues before, this is definitely a valid concern! @mgoin's solution sounds good to me. cc @petersalas |
The optional dependency makes sense to me. I also filed an issue in |
FWIW I suspect we could also replace the usage of librosa with soundfile. I think there's one place in Ultravox we use librosa for resampling if necessary but we could make that conditional on librosa being present and/or fail if the sample rate is wrong. |
I think we should address this ASAP |
@laurens-gs we have made |
This solution works great for me! Cannot test it until it hits PyPi, but I do not expect issues. |
@laurens-gs you can test with the per-commit wheel. see https://docs.vllm.ai/en/latest/getting_started/installation.html :
|
Your current environment
Since vLLM 0.5.5 there is a dependency on Librosa, which in turn depends on soxr. Soxr is LGPL licensed which is a big red flag for many corporations. I'm not a legal expert but I do understand that LGPL is more permissive than regular GPL or AGPL. However many large firms still consider it too risky and block any LGPL license by default and as a result I am now no longer able to install vLLM in my firm (Fortune 50 size).
I would kindly request to reconsider the use of Librosa.
The text was updated successfully, but these errors were encountered: