Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Installation]: LGPL license in dependencies #8030

Closed
laurens-gs opened this issue Aug 30, 2024 · 8 comments · Fixed by #8063
Closed

[Installation]: LGPL license in dependencies #8030

laurens-gs opened this issue Aug 30, 2024 · 8 comments · Fixed by #8063
Labels
installation Installation problems

Comments

@laurens-gs
Copy link

laurens-gs commented Aug 30, 2024

Your current environment

Since vLLM 0.5.5 there is a dependency on Librosa, which in turn depends on soxr. Soxr is LGPL licensed which is a big red flag for many corporations. I'm not a legal expert but I do understand that LGPL is more permissive than regular GPL or AGPL. However many large firms still consider it too risky and block any LGPL license by default and as a result I am now no longer able to install vLLM in my firm (Fortune 50 size).

I would kindly request to reconsider the use of Librosa.

@laurens-gs laurens-gs added the installation Installation problems label Aug 30, 2024
@mgoin
Copy link
Collaborator

mgoin commented Aug 30, 2024

Perhaps we could move audio support to an "extra" optional dependency and instruct users to install using pip install vllm[audio] for that functionality, like the similar transformers[audio] extra
https://github.com/huggingface/transformers/blob/b127fb8fdc33ff494a04ec91cccbf32d2c1add9c/setup.py#L300

@DarkLight1337
Copy link
Member

I didn't consider licensing issues before, this is definitely a valid concern! @mgoin's solution sounds good to me.

cc @petersalas

@robertgshaw2-neuralmagic
Copy link
Collaborator

The optional dependency makes sense to me. I also filed an issue in librosa to see if they can remove soxr.

@petersalas
Copy link
Contributor

FWIW I suspect we could also replace the usage of librosa with soundfile. I think there's one place in Ultravox we use librosa for resampling if necessary but we could make that conditional on librosa being present and/or fail if the sample rate is wrong.

@robertgshaw2-neuralmagic
Copy link
Collaborator

FWIW I suspect we could also replace the usage of librosa with soundfile. I think there's one place in Ultravox we use librosa for resampling if necessary but we could make that conditional on librosa being present and/or fail if the sample rate is wrong.

I think we should address this ASAP

@ywang96
Copy link
Member

ywang96 commented Sep 1, 2024

@laurens-gs we have made librosa an optional dependency of vLLM. Let us know if you have any other concern.

@laurens-gs
Copy link
Author

@laurens-gs we have made librosa an optional dependency of vLLM. Let us know if you have any other concern.

This solution works great for me! Cannot test it until it hits PyPi, but I do not expect issues.

@youkaichao
Copy link
Member

@laurens-gs you can test with the per-commit wheel. see https://docs.vllm.ai/en/latest/getting_started/installation.html :

vLLM also publishes a subset of wheels (Python 3.10, 3.11 with CUDA 12) for every commit since v0.5.3. You can download them with the following command:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants