Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Multi Lora Bug with different LORAS #7169

Closed
devlup opened this issue Aug 5, 2024 · 3 comments
Closed

[Bug]: Multi Lora Bug with different LORAS #7169

devlup opened this issue Aug 5, 2024 · 3 comments
Labels
bug Something isn't working stale

Comments

@devlup
Copy link

devlup commented Aug 5, 2024

Your current environment

In this example https://github.com/vllm-project/vllm/blob/main/examples/multilora_inference.py  if you gave two different loras instead of same loras with different name, the output is coming from the first lora initialized ```


### 🐛 Describe the bug

give two  any two different loras and do inference, the model is pocking only the first lora in order , the second one inference also coming from the first lora(
            "[user] Write a SQL query to answer the question based on the table schema.\n\n context: CREATE TABLE table_name_74 (icao VARCHAR, airport VARCHAR)\n\n question: Name the ICAO for lilongwe international airport [/user] [assistant]", 
            SamplingParams(temperature=0.0,
                           logprobs=1,
                           prompt_logprobs=1,
                           max_tokens=128,
                           stop_token_ids=[32003]),
            LoRARequest("sql-lora2", 2, lora_path)),
        (
            "my nam is", 
            SamplingParams(n=3,
                           best_of=3,
                           use_beam_search=True,
                           temperature=0,
                           max_tokens=128,
                           stop_token_ids=[32003]),
            LoRARequest("sql-lora", 1, 'timdettmers/qlora-flan-7b')),
@devlup devlup added the bug Something isn't working label Aug 5, 2024
@devlup
Copy link
Author

devlup commented Aug 5, 2024

@Yard1 @jvmncs @rkooo567

Copy link

github-actions bot commented Nov 4, 2024

This issue has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this issue should remain open. Thank you!

@github-actions github-actions bot added the stale label Nov 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

This issue has been automatically closed due to inactivity. Please feel free to reopen if you feel it is still relevant. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

1 participant