Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: v0.4.2 python3.8 TypeError: 'type' object is not subscriptable (python3.9 syntax) #4617

Closed
Theodotus1243 opened this issue May 6, 2024 · 3 comments · Fixed by #4623
Labels
bug Something isn't working

Comments

@Theodotus1243
Copy link

Your current environment

The output of `python collect_env.py`

🐛 Describe the bug

python -m vllm.entrypoints.openai.api_server --model microsoft/Phi-3-mini-4k-instruct --dtype auto --max-model-len 2000

Error

File ".../python3.8/site-packages/vllm/entrypoints/openai/api_server.py", line 37, in <module>
    _running_tasks: Set[asyncio.Task[Any]] = set()
TypeError: 'type' object is not subscriptable

Used python3.10 syntax

@Theodotus1243 Theodotus1243 added the bug Something isn't working label May 6, 2024
@Theodotus1243 Theodotus1243 changed the title [Bug]: v0.4.2 python3.8 error [Bug]: v0.4.2 python3.8 TypeError: 'type' object is not subscriptable May 6, 2024
@Theodotus1243 Theodotus1243 changed the title [Bug]: v0.4.2 python3.8 TypeError: 'type' object is not subscriptable [Bug]: v0.4.2 python3.8 TypeError: 'type' object is not subscriptable (python3.9 syntax) May 6, 2024
@youkaichao
Copy link
Member

cc @rkooo567 is this file checked by mypy? It is strange that it passes mypy checking.

@DarkLight1337
Copy link
Member

cc @rkooo567 is this file checked by mypy? It is strange that it passes mypy checking.

I guess that type checking is disabled for imported items due to setting follow_imports = "skip".

@rkooo567
Copy link
Collaborator

rkooo567 commented May 6, 2024

Also it is not fully covering every case yet. I made is type check subdirectories, but cross directories are not checked yet (it requires us to pass mypy vllm/ --config... which requires another 200 issues to fix). I am planning to make a PR for it this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants