Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Error when running pytest: TypeError: 'ABCMeta' object is not subscriptable #4081

Closed
kevinbu233 opened this issue Apr 15, 2024 · 4 comments · Fixed by #4092
Closed

[Bug]: Error when running pytest: TypeError: 'ABCMeta' object is not subscriptable #4081

kevinbu233 opened this issue Apr 15, 2024 · 4 comments · Fixed by #4092
Labels
bug Something isn't working

Comments

@kevinbu233
Copy link
Contributor

Your current environment

When calling python collect_env.py, running into the same error as below.

🐛 Describe the bug

Encountering the below issue when running tests. Suspected to be related to mypy changes
image
@kevinbu233 kevinbu233 added the bug Something isn't working label Apr 15, 2024
@simon-mo
Copy link
Collaborator

@rkooo567 I think this is from the mypy change.

@youkaichao
Copy link
Member

@kevinbu233 one quick fix: add from __future__ import annotations in the top of vllm/core/interfaces.py.

@rkooo567
Copy link
Collaborator

Sorry for the inconvenience. I will make a PR to fix it in a couple hours

@rkooo567 rkooo567 mentioned this issue Apr 15, 2024
Merged
@rkooo567
Copy link
Collaborator

PR is at #4092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Typing] Fix Sequence type GenericAlias only available after Python 3.9. rkooo567/vllm
4 participants
@rkooo567 @simon-mo @youkaichao @kevinbu233