Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livez and readyz are missing from the api_server #1245

Closed
petrosbaltzis opened this issue Oct 2, 2023 · 2 comments
Closed

livez and readyz are missing from the api_server #1245

petrosbaltzis opened this issue Oct 2, 2023 · 2 comments

Comments

@petrosbaltzis
Copy link

Hello,

I am trying to deploy an LLM model using vLLM on Kubernetes. However, for K8, the readinessProbe and livenessProbe are needed to indicate the health of the api-server and these endpoints are missing from the api_server.py

For that reason I have raised a simple PR to include the needed endpoints: #1244

Regards,
Petros Baltzis

@jc-louis
Copy link

one health endpoint was added #1540

@petrosbaltzis
Copy link
Author

Thanks for that! We already started using it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants