Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to do speculative sampling with vllm? #1042

Closed
lsy643 opened this issue Sep 14, 2023 · 2 comments
Closed

How to do speculative sampling with vllm? #1042

lsy643 opened this issue Sep 14, 2023 · 2 comments

Comments

@lsy643
Copy link

lsy643 commented Sep 14, 2023 •
edited
Loading

When I want to use speculative sampling in the vllm, in the generation step, the number of input tokens of each sequence is larger than one, and then error "an illegal memory access was encountered" is reported.

Can you guys suggest a way to support speculative sampling with vllm?

Thanks a lot
@lsy643 lsy643 changed the title Can the Op single_query_cached_kv_attention in PageAttention Support Multiple token in one sequence? How to do speculative sampling with vllm? Sep 14, 2023
@casper-hansen
Copy link
Contributor

I would love to see speculative decoding implemented in vLLM as it could potentially 2x the throughput. It's not possible at the moment, though.

@cadedaniel
Copy link
Collaborator

It is currently not possible. Once #2188 is done, you can enable it.

@hmellor hmellor closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cadedaniel @lsy643 @hmellor @casper-hansen