Svelte 5 support

[geoextra]

When using the Calendar component in a Svelte 5 project it relies on get_current_component() from svelte/internal which has been removed.

calendar/packages/core/src/Calendar.svelte

Line 4 in d337436

import {destroy_component, get_current_component} from 'svelte/internal';

A possible solution is presented here with an example.

Tested with Svelte 5.0.0-next.50.

[vkurko]

Thanks for the tip. Svelte 5 support will definitely come in the future.

[bayaderpack]

This is not only place with svelte/internal there is like 100 more places unfortunately

[dummdidumm]

Svelte maintainer here. I'm interested in why you had to reach into svelte/internal. When you start the migration towards Svelte 5, I'm curious to hear if there's anything that Svelte 5 lacks that you need to not reach into internals again.

[vkurko]

Svelte maintainer here. I'm interested in why you had to reach into svelte/internal. When you start the migration towards Svelte 5, I'm curious to hear if there's anything that Svelte 5 lacks that you need to not reach into internals again.

Author of Event Calendar here 😃. @dummdidumm Thanks for the intervention. I would like to inform you that at the moment the migration to Svelte 5 has not yet been carried out.

The reason for using svelte/internal is that there are really useful functions there that will already be present in the final code, so it makes sense to reuse them in my library rather than write my own code. And for example get_current_component() it is impossible to write my own analogue.

[HoekWax]

Hello @vkurko, do you have a date in mind for svelte 5 support or not yet ? Thanks

[vkurko]

Not yet, unfortunately. Any help in this matter, including sponsorship, is welcome.

[itsmikesharescode]

I love this project hoping for svelte 5 support!

[rgon]

I have made an attempt at fixing this. I have vendorized the svelte/internal methods that are used and shouldn't be used now.

However, in this attempt, I have dropped support for the destroy() method. It's the only method that requires get_current_component from the internal API, which is quite conflictive. Also, if I may ask so, what's the point of having a destroy() method? Especially now that it bypasses the internal workings of Svelte, and this is the only library I've seen do this. You could achieve the following with the idiomatic:

{#if notDestroyed}
<Calendar />
{/if}

This would call all the built in constructors/destructors and not cause the potential void/null object situation destroying the element manually would.

AFAIK, we cannot implement the solution mentioned by @geoextra would not allow to call the destruct method from within the component, but rather from an external class.

[vkurko]

I have vendorized the svelte/internal methods that are used and shouldn't be used now.

Thank you for your contribution! I will review and accept your PR later.

[vkurko]

what's the point of having a destroy() method?

This method is required when using the library outside of Svelte. The simplest example is using the Event Calendar inside a Vue.js component, where when the Vue component is destroyed, the calendar should be destroyed too.

You could achieve the following with the idiomatic:

{#if notDestroyed}
<Calendar />
{/if}

Well, this is not exactly the equivalent of the current solution. It involves another wrapper component that will hide from the outside world all the methods of the Calendar component that it exposes.

I'm still looking for a solution.

[dummdidumm]

If this should be usable standalone, I suggest to create a index.js from which you expose a custom method that suits your use case, using mount and unmount from svelte:

import { mount, unmount } from 'svelte';
import Calendar from './Calendar.svelte';

export function create(target, props) {
  const instance = mount(Calendar, { target, props });
  return {
     instance,
     destroy: () => unmount(instance)
  }
}

[vkurko]

v3.6.0 is now available with fixes from @rgon. The destroy() method remains available only in pure JS and pre-built versions of the library.

[vkurko]

v3.6.0 is now available with fixes from @rgon. The destroy() method remains available only in pure JS and pre-built versions of the library.

Sorry, in v3.6.0 the destroy is only available in pre-built version. The ES version will be fixed in the future release.

[vkurko]

The ES version will be fixed in the future release.

Done in v3.6.1.