disable gc_log_opts gc_tune options in favor of java_options

[vkhatri]

for solr v5.2.x comp we have added two new attribute default['solrcloud']['solr_config']['gc_log_opts'] and default['solrcloud']['solr_config']['gc_tune'] to the cookbook.

IMHO, it would be better to just use node['solrcloud']['java_options'] and drop both of them completely.

this provides simplicity.

creating this issue in case of any objection.

[vkhatri]

looks like bin/solr has some hardcoded values for both GC_LOG_OPTS and GC_TUNE

if [ "$GC_LOG_OPTS" != "" ]; then
  GC_LOG_OPTS=($GC_LOG_OPTS "-Xloggc:$SOLR_LOGS_DIR/solr_gc.log")

  if [ "${JAVA_VERSION:0:3}" == "1.7" ]; then
    # Specific Java version hacking
    GC_TUNE+=('-XX:CMSFullGCsBeforeCompaction=1' '-XX:CMSTriggerPermRatio=80')
    JAVA_MINOR_VERSION=${JAVA_VERSION:(-2)}
    if [[ $JAVA_MINOR_VERSION -ge 40 && $JAVA_MINOR_VERSION -le 51 ]]; then
      GC_TUNE+=('-XX:-UseSuperWord')