Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: End with newline #45

Closed
claudiojs opened this issue Dec 11, 2014 · 2 comments
Closed

JS: End with newline #45

claudiojs opened this issue Dec 11, 2014 · 2 comments

Comments

@claudiojs
Copy link

Hi! Thanks for writing this task!

I was wondering why I can't use this option:
https://github.com/beautify-web/js-beautify/blob/master/js/lib/beautify.js#L75

Then I figured it out that the task allways inserts a newline after beautifying a JavaScript file - something that I dont't want to. It is unfortunately impossible to configure it with the parameter options. Could you please change this?

Here is the code that I mean:

return [jsBeautify.js, config.js, true];

and here:

// jsbeautifier would skip the line terminator for js files

@vkadam
Copy link
Owner

vkadam commented Mar 8, 2015

This was done way before "end_with_newline" options was added to js-beautify, this was the pull request for it #5.

There is also a pull request #46 for fix but test cases are failing. I will get it correct and honor "end_with_newline"

@vkadam
Copy link
Owner

vkadam commented Mar 8, 2015

Pushed fix in version 0.2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants