Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame model uses data domain instead of domain from config #39

Closed
angiehjort opened this issue Dec 3, 2020 · 1 comment
Closed

Frame model uses data domain instead of domain from config #39

angiehjort opened this issue Dec 3, 2020 · 1 comment

Comments

@angiehjort
Copy link
Member

image

on the picture above the last point in time goes to zero, this is because very few datapoints are available for last year 2018, i wonder if i can somehow tell vizabi to not include the last point?

          frame: {
            modelType: "frame",
            speed: 200,
            scale: {
              domain: ["1971", "2017"]
            },
            data: {
              concept: {
                autoconfig: {
                  concept_type: "time"
                }
              }
            }
          }

i’m trying this, but domain defaults to 1971 - 2018

hmm, it might be using data domain instead of scale domain
image

@jheeffer
Copy link
Collaborator

Should be capped to scale domain now

image

But it seems chart drawing code is not up to par yet:

viz.model.markers.line.encoding.frame.scale.config.domain = ['1975','2012']

image

When dragging:
image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants