Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scope): ✨ add option to disable scope prompt #95

Merged
merged 2 commits into from
Mar 22, 2021
Merged

feat(scope): ✨ add option to disable scope prompt #95

merged 2 commits into from
Mar 22, 2021

Conversation

yi-Xu-0100
Copy link
Collaborator

Add conventionalCommits.promptScopes option to disable scope prompt.

Close #43

@yi-Xu-0100 yi-Xu-0100 added the wait-to-build PR wait to build package. label Mar 21, 2021
@github-actions
Copy link
Contributor

The beta extension of this pull has been built in the workflow! 🎉
Download vscode-conventional-commits-bf1ce8b.vsix in artifacts. 🚀

@github-actions github-actions bot removed the wait-to-build PR wait to build package. label Mar 21, 2021
@yi-Xu-0100 yi-Xu-0100 requested a review from vivaxy March 21, 2021 09:00
vivaxy
vivaxy approved these changes Mar 22, 2021
View reviewed changes
Copy link
Owner

@vivaxy vivaxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥂Awesome work!

Will we have promptTypes, promptSubject... in the future?

@yi-Xu-0100
Copy link
Collaborator Author

@vivaxy I will add them if there is any issue about it. 😀

@yi-Xu-0100 yi-Xu-0100 merged commit a35bc7b into vivaxy:master Mar 22, 2021
@yi-Xu-0100 yi-Xu-0100 deleted the add-option-promptScopes branch March 22, 2021 00:30
@yi-Xu-0100
Copy link
Collaborator Author

Will we have promptTypes, promptSubject... in the future?

@vivaxy I will add them if there is any issue about it. 😀

Unbelievable it happened too fast! 🚑

This was referenced Mar 31, 2021
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivaxy vivaxy vivaxy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to disable scope prompt
2 participants
@yi-Xu-0100 @vivaxy