Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] location lookup without android.location.Geocoder #1062

Open
Sjors opened this issue Sep 6, 2024 · 0 comments
Open

[FEATURE] location lookup without android.location.Geocoder #1062

Sjors opened this issue Sep 6, 2024 · 0 comments

Comments

@Sjors
Copy link

Sjors commented Sep 6, 2024

On my Pixel 7 with GrapheneOS, the app is unable to look up my own location even though I gave it location permission. I just get a spinner.

I'm also not seeing the location for posts that has a g tag.

Looking at the source code, it seems you're using android.location.Geocoder to convert GPS coordinates (obtained from either the geohash or the device GPS) to a human readable name.

Unfortunately that doesn't work in GrapheneOS: GrapheneOS/os-issue-tracker#2302 (comment)

I remember that this feature used to work a year or so ago. I was able to post pictures with a geohash and find others. E.g. this post: https://njump.me/nevent1qvzqqqqqqypzpp59a0hkv5ecm45nrckvmu7pnk0sukssvly33u3wwzquy4v037hcqyg8wumn8ghj7mn0wd68ytnddakj7qgwwaehxw309ahx7uewd3hkctcqypwy03qsvapsyrp5gczglz0sxx4uss77knmkfaxgpn4wdxkj59euy9lj05d

I think I used Amethyst for that post, but I'm not 100% sure. However the use of Geocoder has been in place since 1098c31.

One very simple improvement could be to just show the raw geohash on existing posts, so at searching for other pictures in the same area will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant