Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vitest): show unrelated failed tests when rerunning a test #6022

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

sheremet-va
Copy link
Member

Description

This PR fixes a situation when a test rerun would delete information about previously failed tests from the terminal making it harder to fix failed tests. We still do not print failed errors to not clutter the output with potentially irrelevant errors, but we do print previously failed files and test names.

Closes #4997

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va merged commit 91ba6f9 into vitest-dev:main Jul 2, 2024
15 of 16 checks passed
@sheremet-va sheremet-va deleted the fix/show-failed-tests branch July 2, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rerun on save not covering other test files
1 participant