feat(ui): allow run individual tests/suites from the UI #6641
+78
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userquin
commented
Oct 5, 2024
chore: update run button title based on type
userquin
commented
Oct 6, 2024
6 tasks
userquin
commented
Oct 6, 2024
sheremet-va
requested changes
Oct 8, 2024
sheremet-va
requested changes
Oct 8, 2024
packages/vitest/src/node/core.ts
Outdated
| await this.changeNamePattern( | ||
| task.name, | ||
| [task.file.filepath], | ||
| this.isSuite(task) ? 'rerun suite' : 'rerun test', |
There was a problem hiding this comment.
task.type === 'suite' is how you check for suite, no need for extra function
packages/vitest/src/node/core.ts
Outdated
|
|
||
| async rerunTask(id: string) { | ||
| const task = this.state.idMap.get(id) | ||
| if (task) { |
There was a problem hiding this comment.
maybe we should throw an error if task it not found?
There was a problem hiding this comment.
yeah, I'll ask you about this... or maybe we can rerun all files or passing the filename back again and rerun all tasks in the file
There was a problem hiding this comment.
yeah, something like Task ${id} was not found
sheremet-va
previously approved these changes
Nov 7, 2024
|
Looks good! There are a few conflicts though |
…l-tests-and-suites # Conflicts: # packages/ui/client/components/explorer/ExplorerItem.vue # packages/ui/client/composables/client/index.ts # packages/vitest/src/node/core.ts
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sheremet-va
changed the title
|
Sorry to ask, but can you resolve the conflict again? |
…l-tests-and-suites # Conflicts: # packages/vitest/src/node/core.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need this PR #6405
Since we don't have the full tree in the state (missing parent in task), the client will send the task id, the children ids and all parent ids: parent ids are required to avoid mark the test not being run as skipped and so their state will not change.
We also need to reset
configOverride.testNamePatternwhen re-running some file (including all files), otherwise we can only re-run previous test/suite run, maybe we can have some side effect here (I need to do some additional tests).Caution
Right now the command line will skip other tests/suites not matching the pattern (using t + regexp): the problem with the UI is about enabling/disabling re-run button, disabled when test/suite without state or state with
skiportodovalue (check command line filter behaviour screenshot below)Warning
We should add the
test "path"when filtering tests/suites (check filtering from command line screenshot below)resolves #6638
filtering from command line
command line filter behaviour
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.