type check not work

[rikisamurai]

Describe the bug

I followed the official examples to use Vitest and Vite for type checking, but even when there are type errors, no errors are reported, and the test cases still pass.

import { expect, expectTypeOf, test } from 'vitest'

test('type', () => {
    expectTypeOf(1).toEqualTypeOf('2')
    expectTypeOf({ a: 11 }).toEqualTypeOf<{ a: string }>();
    expect(1).toBe(2) // not executed
})

there are type errors, but still pass.

Reproduction

stackBlitz: https://stackblitz.com/~/github.com/rikisamurai/vitest-issue

or

 npm create vite@latest my-app -- --template react-ts

and follow https://github.com/vitest-dev/vitest/blob/main/examples/typecheck/test/type.test-d.ts

System Info

System:
    OS: macOS 14.2.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 170.70 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.1 - ~/.nvm/versions/node/v20.11.1/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.1/bin/npm
    pnpm: 9.10.0 - ~/Library/pnpm/pnpm
    bun: 1.1.26 - ~/.bun/bin/bun
  Browsers:
    Chrome: 128.0.6613.121
    Safari: 17.2.1
  npmPackages:
    @vitejs/plugin-react: ^4.3.1 => 4.3.1 
    @vitest/ui: ^2.0.5 => 2.0.5 
    vite: ^5.4.1 => 5.4.2 
    vitest: ^2.0.5 => 2.0.5

Used Package Manager

pnpm

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[AriPerkkio]

Your tsconfig.json doesn't include any files.

{
  "files": [],
  "references": [
    { "path": "./tsconfig.app.json" },
    { "path": "./tsconfig.node.json" }
  ]
}

By default Vitest uses the tsconfig.json that it can find: https://vitest.dev/config/#typecheck-tsconfig

So to make your repro work, let's define one of those custom tsconfig.json files in Vitest config:

export default defineConfig({
  plugins: [react()],
  test: {
    typecheck: {
      enabled: true,
+     tsconfig: 'tsconfig.app.json'
    },
  },
})

[rikisamurai]

Your tsconfig.json doesn't include any files.

{
  "files": [],
  "references": [
    { "path": "./tsconfig.app.json" },
    { "path": "./tsconfig.node.json" }
  ]
}

By default Vitest uses the tsconfig.json that it can find: https://vitest.dev/config/#typecheck-tsconfig

So to make your repro work, let's define one of those custom tsconfig.json files in Vitest config:

export default defineConfig({
  plugins: [react()],
  test: {
    typecheck: {
      enabled: true,
+     tsconfig: 'tsconfig.app.json'
    },
  },
})

Thank you very much for your help❤️!
Is it expected that Vitest won't refer to references in this situation? Many beginners, like me, might encounter this issue after creating a project using the Vite template and then adding Vitest.

[AriPerkkio]

Oh right, there's references. Vitest uses tsc --noEmit --pretty false -p tsconfig.json to run the typechecks. Looks like references do not emit any type errors when --build flag is not used.

[mrazauskas]

See #3752. The references related behaviour was discussed there.

[AriPerkkio]

Thanks @mrazauskas, let's track this on #3752.