feat(expect): add toHaveBeenCalledAfter and toHaveBeenCalledBefore utility
#6056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barbapapazes
changed the title
toHaveBeenCalledAfter and toHaveBeenCalledBefore utilitytoHaveBeenCalledAfter and toHaveBeenCalledBefore utility
sheremet-va
requested changes
Jul 9, 2024
packages/expect/src/jest-expect.ts
Outdated
| function (resultSpy: MockInstance) { | ||
| const expectSpy = getSpy(this) | ||
|
|
||
| const [firstExpectSpyCall] = expectSpy.mock.invocationCallOrder |
There was a problem hiding this comment.
Why first? Shouldn't it be the smallest?
There was a problem hiding this comment.
As the calls are ordered in the table (so the first one is always the smallest), I thought that taking the first was enough, but maybe I'm wrong?
sheremet-va
reviewed
Jul 9, 2024
sheremet-va
requested changes
Jul 11, 2024
sheremet-va
previously approved these changes
Oct 2, 2024
4 tasks
sheremet-va
force-pushed
the
feat/have-been-called-before-after
branch
from
d083215
to
0608b91
Compare
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #6045
Hello 👋,
This is my first contribution to Vitest so I really appreciate your feedback.
This PR adds two new test APIs:
toHaveBeenCalledBefore- checks if a spy was called before another spytoHaveBeenCalledAfter- checks if a spy was called after another spyThe implementation will take a look at the invocation order (first call) of the spies and compare them to determine if the spies were called in the correct order.
I add them to
packages/expect/src/jest-expect.tsbut I'm not sure if this is the best place for them. I also update types but I'm not sure if I did it correctly so I would appreciate your feedback on that.I add related tests to for these new APIs.
Once everything is ok for you, I will add related documentation!
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.