Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The input and output looks all the same, but occurs an error #3847

Closed
6 tasks done
PuffMeow opened this issue Jul 30, 2023 · 6 comments
Closed
6 tasks done

The input and output looks all the same, but occurs an error #3847

PuffMeow opened this issue Jul 30, 2023 · 6 comments

Comments

@PuffMeow
Copy link

Describe the bug

image

Reproduction

System Info

System:
    OS: Windows 10 10.0.19045
    CPU: (16) x64 Intel(R) Core(TM) i7-10875H CPU @ 2.30GHz
    Memory: 3.54 GB / 15.79 GB
  Binaries:
    Node: 18.15.0 - D:\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Local\pnpm\yarn.CMD
    npm: 8.6.0 - D:\npm\node_global\npm.CMD
    pnpm: 8.6.9 - ~\AppData\Local\pnpm\pnpm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (113.0.1774.42)
    Internet Explorer: 11.0.19041.1566

Used Package Manager

pnpm

Validations

@github-actions
Copy link

Hello @PuffMeow. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with need reproduction will be closed if they have no activity within 3 days.

@sheremet-va
Copy link
Member

Probably new line is different?

@PuffMeow
Copy link
Author

PuffMeow commented Aug 1, 2023

@sheremet-va Please see this repo: https://github.com/PuffMeow/schema2ts

steps:

1.pnpm i

2.pnpm run test

finally you will see test6 failed

image

@PuffMeow
Copy link
Author

PuffMeow commented Aug 1, 2023

I can't find what's wrong with it.

@ghiscoding
Copy link
Contributor

ghiscoding commented Aug 2, 2023

@PuffMeow as suggested, you should look at the line ending which might be the difference and is invisible to the user, most CI use Unix line ending (LF) while on Windows it's CRLF and tests could pass locally but fail in CI and vice/versa

image

@PuffMeow
Copy link
Author

PuffMeow commented Aug 3, 2023

@PuffMeow as suggested, you should look at the line ending which might be the difference and is invisible to the user, most CI use Unix line ending (LF) while on Windows it's CRLF and tests could pass locally but fail in CI and vice/versa

image

Wow, it seems like that, I try to change the end of line to LF, it works correctly.

@PuffMeow PuffMeow closed this as completed Aug 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants