expect.toHaveReturned does not return true when a mock function is updated to return value

[trivikr]

Describe the bug

expect.toHaveReturned does not return true when a mock function is updated to return value

Reproduction

Code:

import { expect, test, vi } from "vitest";

test("toHaveReturned", () => {
  const mockError = new Error("mockError");
  const mockFn = vi.fn(() => { throw mockError; });

  try {
    mockFn();
  } catch (error) {}
  expect(mockFn).not.toHaveReturned();

  const mockReturn = 42;
  mockFn.mockReturnValue(mockReturn);
  const mockOutput = mockFn();
  expect(mockOutput).toBe(mockReturn);
  expect(mockFn).toHaveReturned(); // <-- This should be true.
});

Output:

AssertionError: expected "spy" to be successfully called at least once
 ❯ src/__fixtures__/expect/toHaveReturned.output.js:15:18
     13|   const mockOutput = mockFn();
     14|   expect(mockOutput).toBe(mockReturn);
     15|   expect(mockFn).toHaveReturned();
       |                  ^
     16| });

  - Expected   "false"
  + Received   "true"

System Info

System:
    OS: macOS 13.1
    CPU: (8) arm64 Apple M1 Pro
  Binaries:
    Node: 18.13.0 - ~/Library/Caches/fnm_multishells/43666_1676070339954/bin/node
    npm: 8.19.3 - ~/Library/Caches/fnm_multishells/43666_1676070339954/bin/npm
  npmPackages:
    vitest: ^0.28.4 => 0.28.4

Used Package Manager

yarn

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[trivikr]

I guess the following line need to check if function had called and returned

vitest/packages/expect/src/jest-expect.ts

Line 552 in 445c7b3

const calledAndNotThrew = spy.mock.calls.length > 0 && !spy.mock.results.some(({ type }) => type === 'throw')

const calledAndNotThrew = spy.mock.calls.length > 0 && spy.mock.results.some(({ type }) => type === "return");

[trivikr]

From vitest docs:

This assertion checks if a function has successfully returned a value at least once (i.e., did not throw an error).

https://vitest.dev/api/expect.html#tohavereturned

[trivikr]

Posted a fix at #2850