Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run vitest typecheck together with normal test in one watch #2299

Closed
4 tasks done
Shinigami92 opened this issue Nov 8, 2022 · 2 comments · Fixed by #4324
Closed
4 tasks done

Run vitest typecheck together with normal test in one watch #2299

Shinigami92 opened this issue Nov 8, 2022 · 2 comments · Fixed by #4324
Assignees
Labels
enhancement New feature or request p3-significant High priority enhancement (priority)

Comments

@Shinigami92
Copy link
Contributor

Clear and concise description of the problem

  • As a user
  • I want to run vitest typecheck and vitest in just one command (e.g. just vitest or vitest --with-typecheck)
  • so that I don't need to run e.g. two separate terminal windows in my VSCode editor in parallel to run all tests while I'm working on my project

Suggested solution

Run typecheck by default alongside the normal running tests by default.
(I use *.test-d.ts as recommended in the docs)

Alternative

Let us use a flag for running with typecheck via --with-typecheck (alternative wording welcome)

Additional context

No response

Validations

@Shinigami92 Shinigami92 changed the title Run typecheck together with normal test in one watch Run vitest typecheck together with normal test in one watch Nov 8, 2022
@sheremet-va sheremet-va added the enhancement New feature or request label Nov 11, 2022
@bugeats
Copy link

bugeats commented Oct 3, 2023

This could also be addressed by adding a shell command hook to run before reload. Ex:

vitest --watch --before-run "tsc --noEmit"

In my case I have multiple things I'd also like to do on re-test: clear my tmux buffer, run lints, etc.

@sheremet-va sheremet-va added the p3-significant High priority enhancement (priority) label Oct 4, 2023
@posva
Copy link
Contributor

posva commented Oct 16, 2023

It would also be nice if they appear in the UI and are reported through the API

@sheremet-va sheremet-va self-assigned this Oct 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request p3-significant High priority enhancement (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants