Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declaration file missing plugin configs #427

Closed
henrist opened this issue Apr 14, 2024 · 0 comments · Fixed by #428
Closed

Declaration file missing plugin configs #427

henrist opened this issue Apr 14, 2024 · 0 comments · Fixed by #428

Comments

@henrist
Copy link
Contributor

henrist commented Apr 14, 2024

#407 changed plugin.configs to be specified using Object.assign. This will not change the type of plugin, so it don't include the assigned configs. As of 0.5.2 the configs property is an empty object, preventing the use of this for type-checked ESLint config files.

I notice the ESLint documentation suggests this approach, but the ESLint project itself don't use TypeScript or emit declaration files, so I assume it's just an oversight.

I'll create a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant