-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure topo read calls consider --topo_read_concurrency
#17276
Draft
timvaillancourt
wants to merge
7
commits into
vitessio:main
Choose a base branch
from
timvaillancourt:topo_read_concurrency-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Ensure topo read calls consider --topo_read_concurrency
#17276
timvaillancourt
wants to merge
7
commits into
vitessio:main
from
timvaillancourt:topo_read_concurrency-refactor
+64
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Vaillancourt <[email protected]>
timvaillancourt
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Type: Performance
Component: VTorc
Vitess Orchestrator integration
Component: VTCombo
Component: VTTablet
Component: VTGate
labels
Nov 23, 2024
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 23, 2024
timvaillancourt
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Nov 23, 2024
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17276 +/- ##
==========================================
+ Coverage 67.37% 67.39% +0.02%
==========================================
Files 1573 1573
Lines 253113 253103 -10
==========================================
+ Hits 170538 170586 +48
+ Misses 82575 82517 -58 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Tim Vaillancourt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: VTCombo
Component: VTGate
Component: VTorc
Vitess Orchestrator integration
Component: VTTablet
NeedsWebsiteDocsUpdate
What it says
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Type: Performance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Resolves #17275
Checklist
Deployment Notes