-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy EmergencyReparentShard
stats
#15941
Remove legacy EmergencyReparentShard
stats
#15941
Conversation
Signed-off-by: Tim Vaillancourt <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Tim Vaillancourt <[email protected]>
EmergencyReparentShard
stats
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15941 +/- ##
==========================================
+ Coverage 68.40% 68.41% +0.01%
==========================================
Files 1556 1562 +6
Lines 195121 197053 +1932
==========================================
+ Hits 133479 134821 +1342
- Misses 61642 62232 +590 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
This PR removes legacy ERS stats that were deprecated by a PR I wrote in Vitess 18.0. Replacement metrics with labels were added in the same release
Related Issue(s)
#13723
Checklist
Deployment Notes