Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-17.0] Examples: only terminate vtadmin if it was started (#13433) #13443

Merged
merged 14 commits into from
Jul 27, 2023
Merged

[release-17.0] Examples: only terminate vtadmin if it was started (#13433) #13443

merged 14 commits into from
Jul 27, 2023

Commits on Jul 3, 2023

  1. Do not error stopping vtadmin web and api if pidd files do not exist. 

    For fixing below.
#13432

Signed-off-by: Jean-François Gagné <[email protected]>
    @jfg956
    jfg956 authored Jul 3, 2023
    Configuration menu
    Copy the full SHA
    29a6f81 View commit details
    Browse the repository at this point in the history

  2. Get rid of code duplication in vtadmin-down.sh. 

    Signed-off-by: Jean-François Gagné <[email protected]>
    @jfg956
    jfg956 authored Jul 3, 2023
    Configuration menu
    Copy the full SHA
    41042eb View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Use bash test 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    5d345d6 View commit details
    Browse the repository at this point in the history

  2. Use SIGTERM and wait for process to end 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    94bce04 View commit details
    Browse the repository at this point in the history

  3. Validate function parameters 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    63f470d View commit details
    Browse the repository at this point in the history

  4. Add license header 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    63cc8bc View commit details
    Browse the repository at this point in the history

  5. Move vtadmin stop function to utils 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c8b742f View commit details
    Browse the repository at this point in the history

  6. Generalize simple process shutdown with timeout 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    8190749 View commit details
    Browse the repository at this point in the history

  7. Correct output 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c153b4b View commit details
    Browse the repository at this point in the history

  8. Remove now redundant log message 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    095e12e View commit details
    Browse the repository at this point in the history

  9. Corrections 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    0a9d320 View commit details
    Browse the repository at this point in the history

  10. Add missing license header to modified file 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    b16e303 View commit details
    Browse the repository at this point in the history

  11. Only check PID if we killed it 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    693501c View commit details
    Browse the repository at this point in the history

  12. Remove mix of spaces and tabs 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    4c7bc58 View commit details
    Browse the repository at this point in the history