Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-17.0] Examples: only terminate vtadmin if it was started (#13433) #13443

Merged
merged 14 commits into from
Jul 27, 2023
Merged

[release-17.0] Examples: only terminate vtadmin if it was started (#13433) #13443

merged 14 commits into from
Jul 27, 2023

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jul 5, 2023

Description

This is a backport of #13433.

jfg956 and others added 14 commits July 3, 2023 19:56
@jfg956
Do not error stopping vtadmin web and api if pidd files do not exist.
29a6f81 
For fixing below.
#13432

Signed-off-by: Jean-François Gagné <[email protected]>
@jfg956
Get rid of code duplication in vtadmin-down.sh.
41042eb 
Signed-off-by: Jean-François Gagné <[email protected]>
@mattlord
Use bash test
5d345d6 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
Use SIGTERM and wait for process to end
94bce04 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
Validate function parameters
63f470d 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
Add license header
63cc8bc 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
Move vtadmin stop function to utils
c8b742f 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
Generalize simple process shutdown with timeout
8190749 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
Correct output
c153b4b 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
Remove now redundant log message
095e12e 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
Corrections
0a9d320 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
Add missing license header to modified file
b16e303 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
Only check PID if we killed it
693501c 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
Remove mix of spaces and tabs
4c7bc58 
Signed-off-by: Matt Lord <[email protected]>
@vitess-bot vitess-bot bot requested a review from deepthi as a code owner July 5, 2023 19:04
@vitess-bot vitess-bot bot added Backport This is a backport Component: Examples Type: Bug NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 5, 2023
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Jul 5, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v17.0.1 milestone Jul 5, 2023
@frouioui frouioui mentioned this pull request Jul 25, 2023
Closed
28 tasks
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jul 27, 2023
@frouioui frouioui merged commit a8d533f into release-17.0 Jul 27, 2023
@frouioui frouioui deleted the backport-13433-to-release-17.0 branch July 27, 2023 09:20
@jjpersch jjpersch mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@mattlord mattlord mattlord approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit

Assignees
No one assigned
Labels
Backport This is a backport Component: Examples Type: Bug
Projects
None yet
Milestone
v17.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mattlord @frouioui @jfg956