Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-17.0] VReplication: Fix VDiff2 DeleteByUUID Query (#13255) #13283

Merged
merged 3 commits into from
Jun 12, 2023
Merged

[release-17.0] VReplication: Fix VDiff2 DeleteByUUID Query (#13255) #13283

merged 3 commits into from
Jun 12, 2023

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jun 9, 2023

Description

This is a backport of #13255.

@mattlord
Fix VDiff2 DeleteByUUID Query
3ecd231 
It was incorrect and thus deleting every row in the vdiff table.
IIRC, this was a mistake on my part as I was first using a WHERE
based query and then had to move to LEFT JOIN usage as there may
not always be vdiff_table records. When doing so, however, I left
the last AND clause in place when it should have become the sole
predicate in a new WHERE clause after the LEFT JOIN condition.

Signed-off-by: Matt Lord <[email protected]>
@mattlord
Add unit test as well
388e8af 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
Minor changes after review
cf25777 
Signed-off-by: Matt Lord <[email protected]>
@vitess-bot vitess-bot bot added Backport This is a backport Component: VReplication Type: Bug NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 9, 2023
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Jun 9, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v17.0.0 milestone Jun 9, 2023
@frouioui frouioui modified the milestones: v17.0.0, v18.0.0 Jun 12, 2023
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jun 12, 2023
@mattlord mattlord merged commit 6f8d885 into release-17.0 Jun 12, 2023
@mattlord mattlord deleted the backport-13255-to-release-17.0 branch June 12, 2023 18:14
@jjpersch jjpersch mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@mattlord mattlord mattlord approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

Assignees
No one assigned
Labels
Backport This is a backport Component: VReplication Type: Bug
Projects
None yet
Milestone
v17.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mattlord @frouioui