Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VReplication: Fix VDiff2 DeleteByUUID Query #13255

Merged
merged 3 commits into from
Jun 9, 2023
Merged

VReplication: Fix VDiff2 DeleteByUUID Query #13255

merged 3 commits into from
Jun 9, 2023

Commits on Jun 6, 2023

  1. Fix VDiff2 DeleteByUUID Query 

    It was incorrect and thus deleting every row in the vdiff table.
IIRC, this was a mistake on my part as I was first using a WHERE
based query and then had to move to LEFT JOIN usage as there may
not always be vdiff_table records. When doing so, however, I left
the last AND clause in place when it should have become the sole
predicate in a new WHERE clause after the LEFT JOIN condition.

Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    1ac8f74 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Add unit test as well 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    d5f81be View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Minor changes after review 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    cac3548 View commit details
    Browse the repository at this point in the history